Moving dice distance from raft to cuvs and support for half types#971
Moving dice distance from raft to cuvs and support for half types#971aamijar wants to merge 20 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
@aamijar I know this isn't your fault, but we're closely monitoring the cuVS binary size going forward and the pairwise distance APIs are by far the largest offender. Can you check the metrics logs that are produced in this PR to see how much this new distance affects the libcuvs binary size? |
|
Hi @cjnolet, sure where can I check the binary size/metrics for this pr? |
|
@aamijar See the conda C++ build logs for the build metrics reports: https://github.com/rapidsai/cuvs/actions/runs/15453622193/job/43501422197#step:14:31 The HTML report here (https://downloads.rapids.ai/ci/cuvs/pull-request/971/59cb596/cuda12_x86_64.compile_lib.html) shows some data for the new files: So at least 7 MB just from the new files. There may be other changes that affect the binary size of existing objects too. Maybe |
|
Thank you @bdice! It would be nice if there was a way to highlight in the html report which files are edited from the PR and the increase or decrease in binary size. |
|
To follow up here are the binary size reports. The
|
|
Is this still targeting 25.12? |
robertmaynard
left a comment
There was a problem hiding this comment.
All new files added via this PR need to use the SPDX header format now
|
This one is not targeting 25.12, and yep will update to add the new header format. |
|
I've removed the cutlass operator and the binary size looks like this now: CUDA 12
CUDA 13
|
Resolves #966