Skip to content

Normalize ucxx branch name #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

Normalize ucxx branch name #493

merged 1 commit into from
Apr 18, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 18, 2025

This PR normalizes ucxx branch names. When running rapids-checkout-same-branch, ucxx is always ignored. Then, if a branch name matching branch-YY.MM is selected, ucxx will use the corresponding branch name for its matching version.

@bdice bdice marked this pull request as ready for review April 18, 2025 21:47
@bdice bdice requested a review from a team as a code owner April 18, 2025 21:47
@bdice bdice requested review from raydouglass and removed request for a team April 18, 2025 21:47
@bdice
Copy link
Contributor Author

bdice commented Apr 18, 2025

I verified locally that this works!

vyasr
vyasr approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! This solution looks good to me. The one edge case is if someone explicitly requests a ucx-style branch version, but I think it's fine for that to be off since you can always explicitly check out those repos in that case.

@bdice
Copy link
Contributor Author

bdice commented Apr 18, 2025 •
edited
Loading

Thanks. I think requesting ucxx-versioned branches is out of scope for this utility, because it'd have to match a branch name for the rest of RAPIDS. Treating ucxx as the special case is better imo.

@bdice bdice merged commit 6c5a878 into rapidsai:branch-25.06 Apr 18, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @vyasr