Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflicts for branch-23.12 into branch-24.02 #621

Merged

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Dec 11, 2023

Resolves #619

This PR should not be squash merged!

raydouglass and others added 3 commits December 7, 2023 19:50
Closes rapidsai#607
Closes rapidsai#614

RAPIDS `23.12` uses `dask` `2023.11.0` (rapidsai/rapids-dask-dependency#6), so need to update `dask-sql` to match (conda-forge/dask-sql-feedstock#78).

This should resolve the conflicts seen here: https://github.com/rapidsai/docker/actions/runs/7130639487/job/19419248901#step:9:235

Authors:
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#617
Replaces rapidsai#616

Adds the `SHELL` instruction to every stage in each Dockerfile.

This ensures an error in any `RUN` will fail the build. Such as https://github.com/rapidsai/docker/actions/runs/7130639487/job/19419248901#step:9:235

Authors:
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#618
@raydouglass raydouglass requested a review from a team as a code owner December 11, 2023 14:55
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raydouglass raydouglass merged commit e1ad8ee into rapidsai:branch-24.02 Dec 11, 2023
@raydouglass raydouglass deleted the branch-24.02-merge-23.12 branch December 11, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants