CURLINFO_RESPONSE_CODE uses long (not int)

rapidsai · Feb 7, 2025 · 58400cb · 58400cb
1 parent 5b7ccbd
commit 58400cb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/cpp/include/kvikio/defaults.hpp b/cpp/include/kvikio/defaults.hpp
@@ -299,7 +299,7 @@ class defaults {
    *
    * @return The list of HTTP status codes to retry.
    */
-  [[nodiscard]] static std::vector<int> http_status_codes();
+  [[nodiscard]] static std::vector<int> const& http_status_codes();
 
   /**
    * @brief Reset the list of HTTP status codes to retry.

diff --git a/cpp/src/defaults.cpp b/cpp/src/defaults.cpp
@@ -176,9 +176,8 @@ defaults::defaults()
   }
   // Determine the default value of `http_status_codes`
   {
-    const std::vector<int> env =
+    _http_status_codes =
       getenv_or("KVIKIO_HTTP_STATUS_CODES", std::vector<int>{429, 500, 502, 503, 504});
-    _http_status_codes = env;
   }
 }
 
@@ -256,7 +255,7 @@ void defaults::max_attempts_reset(std::size_t attempts)
   instance()->_max_attempts = attempts;
 }
 
-std::vector<int> defaults::http_status_codes() { return instance()->_http_status_codes; }
+std::vector<int> const& defaults::http_status_codes() { return instance()->_http_status_codes; }
 
 void defaults::http_status_codes_reset(std::vector<int> status_codes)
 {

diff --git a/cpp/src/shim/libcurl.cpp b/cpp/src/shim/libcurl.cpp
@@ -119,11 +119,11 @@ CURL* CurlHandle::handle() noexcept { return _handle.get(); }
 void CurlHandle::perform()
 {
   CURLcode err;
-  int http_code                      = 0;
-  int attempt_count                  = 1;
-  int baseDelay                      = 100;  // milliseconds
-  std::size_t max_attempts           = kvikio::defaults::max_attempts();
-  std::vector<int> http_status_codes = kvikio::defaults::http_status_codes();
+  long http_code                            = 0;
+  int attempt_count                         = 1;
+  int baseDelay                             = 100;  // milliseconds
+  std::size_t max_attempts                  = kvikio::defaults::max_attempts();
+  std::vector<int> const& http_status_codes = kvikio::defaults::http_status_codes();
 
   while (attempt_count <= max_attempts) {
     std::stringstream ss;