Skip to content

[REVIEW] Fix a few memory leaks. #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[REVIEW] Fix a few memory leaks. #2710

merged 1 commit into from
Jun 20, 2025

Conversation

legrosbuffle
Copy link
Contributor

No description provided.

@legrosbuffle legrosbuffle requested a review from a team as a code owner June 18, 2025 12:54
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp label Jun 18, 2025
bdice
bdice approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like good fixes to me. Thanks @legrosbuffle!

divyegala
divyegala approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @legrosbuffle !

@divyegala
Copy link
Member

/ok to test cbe040b

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Jun 18, 2025
@divyegala
Copy link
Member

@legrosbuffle could you run pre-commit to fix failing style checker?

@legrosbuffle
Copy link
Contributor Author

@legrosbuffle could you run pre-commit to fix failing style checker?

Done, thanks. I force-pushed the fix, I'm not sure what the convention is in this repo ?

@divyegala
Copy link
Member

@legrosbuffle force push is not a problem, we squash merge. Thank you!

@divyegala
Copy link
Member

/ok to test 15411c7

@divyegala
Copy link
Member

@legrosbuffle it seems like your force pushed commit does not have the fixes for passing style checker?

@legrosbuffle
Copy link
Contributor Author

@legrosbuffle it seems like your force pushed commit does not have the fixes for passing style checker?

Sorry, I think it should be good now.

@divyegala
Copy link
Member

/ok to test 01a6cb2

@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9abfca9 into rapidsai:branch-25.08 Jun 20, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@divyegala divyegala divyegala approved these changes

Assignees

@legrosbuffle legrosbuffle

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
Vector Search, ML, & Data Mining Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legrosbuffle @divyegala @bdice