Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Updated" from ComponentUtilities #1666

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Feb 24, 2024

This PR migrates two chunks of code from the ComponentUtilities "updated()" method

Presently, ComponentUtilities contains two checks within it's "updated()" hook:

if ($name === 'search') {
and
if (Str::contains($name, 'filterComponents')) {

Instead, the underlying functionality for these, is migrated to the WithSearch and WithFilters Traits respectively

This:

  • Reduces the number of executions for the ComponentUtilities "updated" method
  • Segregates the logical methods into appropriate traits

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit f20721a into rappasoft:develop Feb 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant