Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.2.1 Release #1667

Merged
merged 4 commits into from
Feb 24, 2024
Merged

V3.2.1 Release #1667

merged 4 commits into from
Feb 24, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Feb 24, 2024

This is the V3.2.1 Release Merge

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 4 commits January 4, 2024 02:36
* Move attributes for columns and filters (#73)

* Add Attributes and Callback as Centralised Traits

* Fix styling

* Initial migration to centralised traits

* Fix styling

* Add default declaration for view

* Fix styling

* Migrate Attributes and View to Common Traits

* Fix styling

* Add HasConfig and HasView traits

* Fix styling

* Update PHPStan - ignore $view in Views\Column

* Fix styling

* Moving LocationCallback

* Fix styling

* Moving More Core Attributes

* Fix styling

* Migate TitleCallback to own Trait

* Fix styling

* Move HeaderFooter to Traits

* Fix styling

* Initial Merge

* Fix styling

* Update Filters

* Fix styling

* Add HtmlString Path

* Add defaults for additional filters

* Fix styling

* Fix Filter MultiSelectDropdownFilter STAN Comp

* Fix styling

* Update MultiSelectFilter

* Fix styling

* Update selectFilter default configuration options

* Fix styling

* Migrate Collapsible,Searchable,Sortable to Traits

* Fix styling

* Tweaks to return types

* Fix styling

* Remove errant getDefaultValue

* Fix full-page-component tests

* Fix styling

* Update Tests - Include HasFullPageComponent Checks

* Fix errant default

* Add Model as parameter for getAttributeBag

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update String Filters

* Enable perPage QueryString

* Fix styling

* Update paginationMethod to protected

* Enable Show/Hide Pagination Details

* Fix styling

* Remove pagination info display adjustments

* Fix styling

* Move Filter Position/Visibility to Traits

* Fix styling

* Update filters

* Fix styling

* Use Core HasVisibility in Filters HasVisibility

* Fix styling

* Update NumberFilter - float|int|bool

* Add new Pagination Methods

* PaginationHelper Merge Fixes

* Fix styling

* Merge Conflict Tweaks

* Fix styling

* MergeConflict Tweaks

* Fix styling

* Merge Conflict Tweak

* Update ChangeLog

* v3.2.0

* Columns - Migrate Visibility & Selectability

* Fix styling

* Update ChangeLog

* Remove duplicate trait

* Test Fixes

* Fix styling

* Add HtmlString test for Column Label getContents

* Fix styling

* Add Format HTML Column Test

* Fix styling

* Add failing test for collapseOnMobile and collapseOnTablet

* Push setCustomView to setView

* Update CHANGELOG.md

* Update changelog

* Update dates on changelog

* ChangeLog Merge Conflict

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Migrate "Updated" from ComponentUtilities

* Fix styling

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
* Collapsing Fix 1.0

* Fix styling

* Hide Reorder When Not Reordering

* Update Changelog & Version

* Update Changelog

---------

Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.12%. Comparing base (b114094) to head (52dac06).
Report is 13 commits behind head on master.

Files Patch % Lines
src/Traits/WithSearch.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1667      +/-   ##
============================================
- Coverage     88.13%   88.12%   -0.01%     
  Complexity     1310     1310              
============================================
  Files           123      123              
  Lines          3102     3100       -2     
============================================
- Hits           2734     2732       -2     
  Misses          368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit d49c0c7 into master Feb 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant