Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Collapsing Columns - Multiple Tables, Single Page #1678

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Mar 2, 2024

This provides a fix by passing the table name, along with the rowIndex to ensure that the correct table is targetted.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe linked an issue Mar 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (ac641df) to head (7527bfd).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1678   +/-   ##
==========================================
  Coverage      88.16%   88.16%           
  Complexity      1314     1314           
==========================================
  Files            123      123           
  Lines           3110     3110           
==========================================
  Hits            2742     2742           
  Misses           368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 6c759e0 into rappasoft:develop Mar 2, 2024
7 checks passed
@lrljoe lrljoe mentioned this pull request Mar 2, 2024
9 tasks
lrljoe added a commit that referenced this pull request Apr 6, 2024
* Update ChangeLog - Showing as UNRELEASED rather than 3.1.8 (#1621)

* Fix CHANGELOG.md missing release

* Fix for Collapsing Columns - Multiple Tables, Single Page (#1678) (#1679)

* Update nl.json

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>
lrljoe added a commit that referenced this pull request Apr 6, 2024
* Update ChangeLog - Showing as UNRELEASED rather than 3.1.8 (#1621)

* Fix CHANGELOG.md missing release

* Fix for Collapsing Columns - Multiple Tables, Single Page (#1678) (#1679)

* Update nl.json

Added missing dutch translation

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple tables collapsible on mobile
1 participant