Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder of requirement to use toggle method #2208

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

da-mask
Copy link

@da-mask da-mask commented Feb 20, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Calling the toggleMethod on a toggleable function on a BooleanColumn requires that the id is selected as part of the query, otherwise nothing is passed in. Took a bit of diving to work out what was going on, hopefully this may save someone some time.

@lrljoe lrljoe changed the base branch from master to development February 28, 2025 04:04
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (6598b25) to head (df4b622).
Report is 27 commits behind head on development.

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2208   +/-   ##
==============================================
  Coverage          91.44%   91.44%           
  Complexity          1995     1995           
==============================================
  Files                212      212           
  Lines               4499     4499           
==============================================
  Hits                4114     4114           
  Misses               385      385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe
Copy link
Collaborator

lrljoe commented Feb 28, 2025

Awesome, to save me a few minutes, please could you add in a link to go to the placeholder for setAdditionalSelects:

datatable/available-methods#content-setadditionalselects

So that it makes it obvious how to add the "id" field in as an additional select via the configure() method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants