Skip to content

Commit

Permalink
fix(explain): corrects livenessProbe examples in packages
Browse files Browse the repository at this point in the history
  • Loading branch information
RomilShah authored and pallabpain committed Sep 4, 2023
1 parent 30c1a83 commit 69b7ad1
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 8 deletions.
2 changes: 1 addition & 1 deletion riocli/apply/manifests/package-nonros-device.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
cpu: 0.025 # Unit: Core (Optional)
memory: 128 # Unit: MB (Optional)
livenessProbe:
http:
httpGet:
path: "/"
port: 90
initialDelaySeconds: 5 # Number of seconds after the container has started before liveness probes are initiated.
Expand Down
4 changes: 2 additions & 2 deletions riocli/apply/manifests/package-ros-device-no-rosbag.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
cpu: 0.025 # Unit: Core (Optional)
memory: 128 # Unit: MB (Optional)
livenessProbe: # Optional
tcp:
tcpSocket:
port: 999
initialDelaySeconds: 5 # Number of seconds after the container has started before liveness probes are initiated.
periodSeconds: 10 # How often (in seconds) to perform the probe.
Expand All @@ -41,7 +41,7 @@ spec:
cpu: 0.025 # Unit: Core (Optional)
memory: 128 # Unit: MB (Optional)
livenessProbe: # Optional
http:
httpGet:
path: "/"
port: 90
initialDelaySeconds: 5 # Number of seconds after the container has started before liveness probes are initiated.
Expand Down
2 changes: 1 addition & 1 deletion riocli/apply/manifests/package-ros-device-rosbag.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
cpu: 0.025 # Unit: Core (Optional)
memory: 128 # Unit: MB (Optional)
livenessProbe: # Optional
http:
httpGet:
path: "/"
port: 90
initialDelaySeconds: 5 # Number of seconds after the container has started before liveness probes are initiated.
Expand Down
25 changes: 21 additions & 4 deletions riocli/apply/manifests/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -407,17 +407,16 @@ spec:
depends:
kind: build
nameOrGUID: "build"
- name: "exec-docker"
- name: "exec-docker-01"
type: docker # Options: [docker (default), build, preInstalled]
command: "roslaunch talker talker.launch"
runAsBash: True
limits: # Optional
cpu: 0.025 # Unit: Core (Optional)
memory: 128 # Unit: MB (Optional)
livenessProbe: # Optional
exec:
command:
- "shell-cmd"
tcpSocket:
port: 8080
initialDelaySeconds: 5 # Number of seconds after the container has started before liveness probes are initiated.
periodSeconds: 10 # How often (in seconds) to perform the probe.
failureThreshold: 1 # Minimum consecutive failures for the probe to be considered failed after having succeeded.
Expand All @@ -430,6 +429,24 @@ spec:
depends:
kind: secret
nameOrGUID: "secret-docker"
- name: "exec-docker-02"
type: docker # Options: [docker (default), build, preInstalled]
runAsBash: True
limits: # Optional
cpu: 0.025 # Unit: Core (Optional)
memory: 128 # Unit: MB (Optional)
livenessProbe: # Optional
httpGet:
path: "/"
port: 80
initialDelaySeconds: 5 # Number of seconds after the container has started before liveness probes are initiated.
periodSeconds: 10 # How often (in seconds) to perform the probe.
failureThreshold: 1 # Minimum consecutive failures for the probe to be considered failed after having succeeded.
successThreshold: 3 # Minimum consecutive successes for the probe to be considered successful after having failed.
timeoutSeconds: 1 # Number of seconds after which the probe times out.
docker:
image: "nginx:latest"
imagePullPolicy: "Always" # Always, Never, IfNotPresent(default)
- name: "exec-preInstalled"
type: preInstalled # Options: [docker (default), build, preInstalled]
command: "roslaunch talker talker.launch"
Expand Down

0 comments on commit 69b7ad1

Please sign in to comment.