Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(staticroutes): adds v2 static routes #181

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

RomilShah
Copy link
Contributor

@RomilShah RomilShah commented Jun 26, 2023

This commit introduces support for V2 static routes

asciicast

Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomilShah Please refer this commit and bring your changes inline with the constants and spinner updates.

da6c993

Once you finish updating this, I will drop the commit from my PR.

@pallabpain pallabpain added the ✏️ needs-work This pull request needs work label Jun 30, 2023
@pallabpain pallabpain changed the base branch from devel to feature/use-yaspin-spinner-in-commands July 3, 2023 07:13
@pallabpain pallabpain changed the base branch from feature/use-yaspin-spinner-in-commands to devel July 3, 2023 07:13
@RomilShah RomilShah changed the title feat(staticroutes): adds v2 static routes ❇️ feat(staticroutes): adds v2 static routes Jul 3, 2023
@RomilShah RomilShah changed the title ❇️ feat(staticroutes): adds v2 static routes ✨ feat(staticroutes): adds v2 static routes Jul 3, 2023
@RomilShah RomilShah changed the base branch from devel to feature/use-yaspin-spinner-in-commands July 3, 2023 15:35
@RomilShah RomilShah changed the base branch from feature/use-yaspin-spinner-in-commands to devel July 3, 2023 15:36
@RomilShah RomilShah removed the ✏️ needs-work This pull request needs work label Jul 20, 2023
@pallabpain pallabpain added the 🔨 refactor Improvements in an existing feature label Jul 25, 2023
@RomilShah RomilShah force-pushed the feat/v2-static-routes branch 3 times, most recently from 9f6d02b to 99e17ed Compare July 28, 2023 08:39
@pallabpain pallabpain added the ✏️ needs-work This pull request needs work label Jul 29, 2023
@pallabpain pallabpain changed the title ✨ feat(staticroutes): adds v2 static routes ✨ feat(staticroutes): adds v2 static routes Jul 29, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 11, 2023
@RomilShah RomilShah force-pushed the feat/v2-static-routes branch 2 times, most recently from 936cf0c to 0e4684f Compare August 21, 2023 09:26
@github-actions
Copy link

🤖 Pull Request Artifacts (#5924453681) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5924460538) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5936398226) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5936587049) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5936941079) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5937205004) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5937393870) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5937444879) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5949064724) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5960190632) 🎉

This commit introduces support for V2 static routes
@github-actions
Copy link

🤖 Pull Request Artifacts (#5996186594) 🎉

@pallabpain pallabpain merged commit 17661c3 into devel Aug 28, 2023
7 checks passed
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the feat/v2-static-routes branch October 1, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ needs-work This pull request needs work 🔨 refactor Improvements in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants