Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(deployment): adds command for updating deployment #190

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

RomilShah
Copy link
Contributor

This commit introduces update deployment command that enables users to conveniently update existing deployments by providing deployment name or regex that can update multiple deployments

Demo: https://asciinema.org/a/F3rWES3S5IHffmfSbapDGVH84

@RomilShah RomilShah requested review from a team as code owners July 5, 2023 10:13
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

🤖 Pull Request Artifacts (#5463073477) 🎉

riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🤖 Pull Request Artifacts (#5475300774) 🎉

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🤖 Pull Request Artifacts (#5475314364) 🎉

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🤖 Pull Request Artifacts (#5475319922) 🎉

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🤖 Pull Request Artifacts (#5476196249) 🎉

Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider making the deployments loop multithreaded to improve the CLI performance.

CHANGELOG.md Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Outdated Show resolved Hide resolved
riocli/deployment/update.py Show resolved Hide resolved
riocli/deployment/update.py Show resolved Hide resolved
@pallabpain pallabpain added ✨ feature A new feature addition to the CLI ✏️ needs-work This pull request needs work labels Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🤖 Pull Request Artifacts (#5483342800) 🎉

riocli/deployment/update.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🤖 Pull Request Artifacts (#5483982169) 🎉

@pallabpain pallabpain changed the title ✨ feat(deployment): adds command for updating deployment ✨ feat(deployment): adds command for updating deployment Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🤖 Pull Request Artifacts (#5484121429) 🎉

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🤖 Pull Request Artifacts (#5484850816) 🎉

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🤖 Pull Request Artifacts (#5491420639) 🎉

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🤖 Pull Request Artifacts (#5491431098) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5530820366) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5532137994) 🎉

@pallabpain pallabpain force-pushed the feat/update-deployment branch 2 times, most recently from 290baa6 to bed629d Compare July 13, 2023 04:43
@github-actions
Copy link

🤖 Pull Request Artifacts (#5539164160) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5539169430) 🎉

@click.option('--update-all', '-a', is_flag=True, default=False,
help='Updates all deployments')
@click.argument('deployment-name-or-regex', type=str, default="")
@click.argument('workers', type=int, default=10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workers should not be an argument. It should be a flag. Follow the convention in Apply command.

@github-actions
Copy link

🤖 Pull Request Artifacts (#5542641035) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5542670251) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5572222153) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5572579430) 🎉

This commit introduces update deployment command that enables users
to conveniently update existing deployments by providing deployment
name or regex that can update multiple deployments

Usage: python -m rio deployment update [OPTIONS]
                                          [DEPLOYMENT_NAME_OR_REGEX]

  Updates one more deployments

Options:
  -f, --force, --silent  Skip confirmation
  -a, --update-all       Updates all deployments
  -w, --workers INTEGER  number of parallel workers while running update
                         deployment command. defaults to 10.
  --help                 Show this message and exit.
@github-actions
Copy link

🤖 Pull Request Artifacts (#5572604608) 🎉

@pallabpain pallabpain merged commit 49a4e3a into devel Jul 17, 2023
3 checks passed
@pallabpain pallabpain deleted the feat/update-deployment branch August 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature A new feature addition to the CLI ✏️ needs-work This pull request needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants