-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(deployment): adds command for updating deployment #190
Conversation
🤖 Pull Request Artifacts (#5463073477) 🎉 |
06f687f
to
b734872
Compare
🤖 Pull Request Artifacts (#5475300774) 🎉 |
b734872
to
8dcd509
Compare
🤖 Pull Request Artifacts (#5475314364) 🎉 |
🤖 Pull Request Artifacts (#5475319922) 🎉 |
8dcd509
to
f59ca8d
Compare
🤖 Pull Request Artifacts (#5476196249) 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider making the deployments loop multithreaded to improve the CLI performance.
🤖 Pull Request Artifacts (#5483342800) 🎉 |
0547763
to
90bd61f
Compare
🤖 Pull Request Artifacts (#5483982169) 🎉 |
90bd61f
to
478251e
Compare
🤖 Pull Request Artifacts (#5484121429) 🎉 |
478251e
to
4e7258b
Compare
🤖 Pull Request Artifacts (#5484850816) 🎉 |
🤖 Pull Request Artifacts (#5491420639) 🎉 |
c18b679
to
373b231
Compare
🤖 Pull Request Artifacts (#5491431098) 🎉 |
373b231
to
416259b
Compare
🤖 Pull Request Artifacts (#5530820366) 🎉 |
416259b
to
7726470
Compare
🤖 Pull Request Artifacts (#5532137994) 🎉 |
290baa6
to
bed629d
Compare
🤖 Pull Request Artifacts (#5539164160) 🎉 |
🤖 Pull Request Artifacts (#5539169430) 🎉 |
riocli/deployment/update.py
Outdated
@click.option('--update-all', '-a', is_flag=True, default=False, | ||
help='Updates all deployments') | ||
@click.argument('deployment-name-or-regex', type=str, default="") | ||
@click.argument('workers', type=int, default=10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workers should not be an argument. It should be a flag. Follow the convention in Apply command.
bed629d
to
e43ca7b
Compare
🤖 Pull Request Artifacts (#5542641035) 🎉 |
e43ca7b
to
aa11dda
Compare
🤖 Pull Request Artifacts (#5542670251) 🎉 |
aa11dda
to
e50fa2d
Compare
🤖 Pull Request Artifacts (#5572222153) 🎉 |
e50fa2d
to
8b279ba
Compare
🤖 Pull Request Artifacts (#5572579430) 🎉 |
This commit introduces update deployment command that enables users to conveniently update existing deployments by providing deployment name or regex that can update multiple deployments Usage: python -m rio deployment update [OPTIONS] [DEPLOYMENT_NAME_OR_REGEX] Updates one more deployments Options: -f, --force, --silent Skip confirmation -a, --update-all Updates all deployments -w, --workers INTEGER number of parallel workers while running update deployment command. defaults to 10. --help Show this message and exit.
8b279ba
to
4528e59
Compare
🤖 Pull Request Artifacts (#5572604608) 🎉 |
This commit introduces update deployment command that enables users to conveniently update existing deployments by providing deployment name or regex that can update multiple deployments
Demo: https://asciinema.org/a/F3rWES3S5IHffmfSbapDGVH84