Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› fix(jsonschema): adds regex pattern to usergroup schema #205

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

pallabpain
Copy link
Member

Description

The usergroup jsonschema had no validation on the group name. This PR fixes that.

Testing

β†’ pipenv run python -m riocli apply ~/workspace/playground/riocli-manifests/usergroup.yaml --dryrun
----- Files Processed ----
/home/pallab/workspace/playground/riocli-manifests/usergroup.yaml
                       Resource Context
--------------------  ------------------
Expected Time (mins)         0.08
Files                         1
Resources                     1
                                                                                                                                                                                      
Resource      Action     Expected Time (mins)
------------  --------  ----------------------
usergroup:aa  CREATE             0.08
                                                                                                                                                                                      
β ‹ Applying... (0:00:00.00)[Err] Object "usergroup:aa" apply failed. Apply will not progress further.
✘ Apply failed. Error: 'aa' does not match '^[a-zA-Z][a-z A-Z0-9-_]{2,61}$'

Failed validating 'pattern' in schema['properties']['metadata']['properties']['name']:
    {'pattern': '^[a-zA-Z][a-z A-Z0-9-_]{2,62}$', 'type': 'string'}

On instance['metadata']['name']:
    'aa' (0:00:00.01)

@pallabpain pallabpain requested review from a team as code owners July 25, 2023 01:32
@pallabpain pallabpain self-assigned this Jul 25, 2023
@pallabpain pallabpain added the πŸ› bug Something isn't working label Jul 25, 2023
@pallabpain pallabpain changed the title fix(jsonschema): adds regex pattern to usergroup schema πŸ› fix(jsonschema): adds regex pattern to usergroup schema Jul 25, 2023
@github-actions
Copy link

πŸ€– Pull Request Artifacts (#5651605558) πŸŽ‰

@github-actions
Copy link

πŸ€– Pull Request Artifacts (#5653201859) πŸŽ‰

@github-actions
Copy link

πŸ€– Pull Request Artifacts (#5654448213) πŸŽ‰

@pallabpain pallabpain merged commit b54518d into devel Jul 25, 2023
3 checks passed
@pallabpain pallabpain deleted the fix/usergroup-jsonschema branch August 6, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants