Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(device): fixes error handling when deleting a device #211

Merged
merged 1 commit into from
Aug 7, 2023
Merged

🐛 fix(device): fixes error handling when deleting a device #211

merged 1 commit into from
Aug 7, 2023

Conversation

pallabpain
Copy link
Member

Description

This PR fixes the error handling in the rio device delete command.

Testing

Before

→ rio device delete test-devices-99
Deleting device test-devices-99 (241d4aa7-acd1-4083-86cb-7ce8756150b6) [y/N]: y
✅ Device deleted successfully

After

→ rio device delete test-devices-99 -f
❌ Failed to delete device: Device has running deployments. Please de-provision them before deleting the device.

@pallabpain pallabpain requested review from a team as code owners August 3, 2023 05:49
@pallabpain pallabpain self-assigned this Aug 3, 2023
@pallabpain pallabpain added the 🐛 bug Something isn't working label Aug 3, 2023
@pallabpain pallabpain changed the title fix(devices): fixes error handling when deleting a device 🐛 fix(devices): fixes error handling when deleting a device Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🤖 Pull Request Artifacts (#5747101131) 🎉

@pallabpain pallabpain changed the title 🐛 fix(devices): fixes error handling when deleting a device 🐛 fix(device): fixes error handling when deleting a device Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🤖 Pull Request Artifacts (#5747109986) 🎉

@pallabpain pallabpain removed the request for review from RomilShah August 3, 2023 05:52
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🤖 Pull Request Artifacts (#5747112625) 🎉

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

🤖 Pull Request Artifacts (#5760941974) 🎉

@pallabpain pallabpain merged commit de7289c into devel Aug 7, 2023
3 checks passed
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 4.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/delete-device branch October 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitsingh21 amitsingh21 amitsingh21 approved these changes

@smrutisenapati smrutisenapati smrutisenapati approved these changes

@ankitrgadiya ankitrgadiya Awaiting requested review from ankitrgadiya ankitrgadiya is a code owner automatically assigned from rapyuta-robotics/io-cli-owner

Assignees

@pallabpain pallabpain

Labels
🐛 bug Something isn't working 🎉 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pallabpain @rr-github-ci-user @amitsingh21 @smrutisenapati