Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(deployment): exposes healthcheck probes for device deployments #213

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

RomilShah
Copy link
Contributor

@RomilShah RomilShah commented Aug 4, 2023

This commit adds support for defining liveness probe. You can set HTTP, EXEC or TCP liveness probe

Demo: https://asciinema.org/a/X6Z2IgL0XXHvSbM5rcvBtPIk1
Manifest: https://drive.google.com/file/d/19KmQ6npDzAm6LGlDkK-DxcfXnddVfwRE/view?usp=sharing

@RomilShah RomilShah added the ✏️ needs-work This pull request needs work label Aug 4, 2023
@RomilShah RomilShah requested review from a team as code owners August 4, 2023 06:57
@RomilShah RomilShah force-pushed the feat/expose_health_checks branch 2 times, most recently from ea133c7 to 611dbc6 Compare August 4, 2023 13:40
@RomilShah RomilShah removed the ✏️ needs-work This pull request needs work label Aug 4, 2023
@pallabpain pallabpain changed the title ✨ feat(deployment): adds support for exposing healthcheck for deployments ✨ feat(deployment): exposes healthcheck probes for device deployments Aug 5, 2023
@pallabpain pallabpain changed the title ✨ feat(deployment): exposes healthcheck probes for device deployments ✨ feat(deployment): exposes healthcheck probes for device deployments Aug 5, 2023
Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add manifests with examples of all types of available probes.

riocli/package/model.py Outdated Show resolved Hide resolved
@pallabpain pallabpain added the ✨ feature A new feature addition to the CLI label Aug 5, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 7, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🤖 Pull Request Artifacts (#5781221158) 🎉

@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 8, 2023
riocli/apply/manifests/package.yaml Outdated Show resolved Hide resolved
riocli/jsonschema/schemas/package-schema.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link

🤖 Pull Request Artifacts (#5921574271) 🎉

Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested in a separate comment. Rest looks good.

@RomilShah RomilShah force-pushed the feat/expose_health_checks branch 3 times, most recently from b7d2486 to 7cc0440 Compare August 21, 2023 10:10
@github-actions
Copy link

🤖 Pull Request Artifacts (#5924887375) 🎉

@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 21, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 21, 2023
@github-actions
Copy link

🤖 Pull Request Artifacts (#5935001381) 🎉

Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the commit formatting.

feat(package): adds liveness probe for device executables

This commit adds the support for liveness probes for device executables where you can define one of HTTP, TCP or EXEC-based probe for your device executables.

@github-actions
Copy link

🤖 Pull Request Artifacts (#5936167148) 🎉

This commit adds the support for liveness probes for device executables where you can define one of HTTP, TCP or EXEC-based probe for your device executables.
@github-actions
Copy link

🤖 Pull Request Artifacts (#5936206927) 🎉

@pallabpain pallabpain merged commit 5a0facc into devel Aug 22, 2023
7 checks passed
@github-actions
Copy link

🤖 Pull Request Artifacts (#5936242006) 🎉

@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the feat/expose_health_checks branch October 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature A new feature addition to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants