Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(update): removes the requirement of privileged access #221

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Aug 9, 2023

Description

This PR fixes the following issues with the rio update command

  • requires privileged access to update the appimage even when the file is at a non-privileged location
  • The file move fails with the error: Invalid cross-device link: '/tmp/tmp354y0nsn/rio' -> '/home/ankit/.local/bin/rio'

Testing

01:43:02 pallab@pop-os appimages 
→ rio version
rio 0.6.0 / SDK 1.11.1

01:43:06 pallab@pop-os appimages 
→ rio update -f
🎉 A newer version (4.0.3) is available.
⚠️ Please consider running as a root user.
❌ Failed to update: [Errno 13] Permission denied: '/usr/local/bin/rio'

01:43:13 pallab@pop-os appimages 
→ doas rio update -f
🎉 A newer version (4.0.3) is available.
✅ Update successful!

01:43:26 pallab@pop-os appimages 
→ doas cp rio /usr/local/bin/

01:43:42 pallab@pop-os appimages 
→ sudo rio update -f
🎉 A newer version (4.0.3) is available.
✅ Update successful!

01:43:51 pallab@pop-os appimages 
→ rio version
rio 4.0.3 / SDK 1.11.1

@pallabpain pallabpain requested review from a team as code owners August 9, 2023 12:43
@pallabpain pallabpain self-assigned this Aug 9, 2023
@pallabpain pallabpain added the 🐛 bug Something isn't working label Aug 9, 2023
@pallabpain pallabpain force-pushed the fix/rio-update branch 2 times, most recently from bd06ef9 to 715f187 Compare August 9, 2023 17:03
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 9, 2023
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🤖 Pull Request Artifacts (#5812102210) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5817287860) 🎉

@github-actions
Copy link

🤖 Pull Request Artifacts (#5830205589) 🎉

@ankitrgadiya
Copy link
Member

I was getting Text file busy exception. It was fixed by adding a remove before the move.

<I> ➜  rio update
🎉 A newer version (4.0.3) is available.
Do you want to update? [y/N]: y
⚠️ Please consider running as a root user.
❌ Failed to update: [Errno 26] Text file busy: '/home/ankit/.local/bin/rio'

@ankitrgadiya ankitrgadiya merged commit 8857138 into devel Aug 11, 2023
8 checks passed
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/rio-update branch October 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants