Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(vpn): displays DNS name in vpn status #233

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

pallabpain
Copy link
Member

Description

This PR fixes the rio vpn status command to show the DNS name of nodes instead of the host name registered with headscale. The DNS name is the one that is resolved by MagicDNS and not the host name and thus, it seems more intuitive to show the DNS name. The host name can be inferred from this name as well.

Testing

→ pipenv run python -m riocli vpn status
ℹ️ VPN is enabled in the project (lgs-hmr-001)

IP           DNS Name                                               OS     Online    Active
-----------  -----------------------------------------------------  -----  --------  --------
100.64.0.12  edge01-kyjqi1iz                                        linux  True      False
100.64.0.1   subnet-router.rapyuta.rio.internal                     linux  True      False
100.64.0.14  inst-byrcmzqxgwwidqucldqgwfkg-lytxbh-7b76946cf9-ksdn7  linux  True      False
100.64.0.11  pop-os                                                 linux  True      False

DNS Suffix: rio-internal-headscale-project-hcoqufftmuvwamhuiydfidas.rio.internal

ℹ️ You are connected to the VPN.
→ ssh rr@edge01-kyjqi1iz
The authenticity of host 'edge01-kyjqi1iz (100.64.0.12)' can't be established.
ED25519 key fingerprint is SHA256:T7Mty+p2emncGYKOfzUU25TjwoyApxV8v0Pt+02PiK0.
This key is not known by any other names
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
Warning: Permanently added 'edge01-kyjqi1iz' (ED25519) to the list of known hosts.
rr@edge01-kyjqi1iz's password: 
rr@edge01:~$ exit
logout
Connection to edge01-kyjqi1iz closed.

@pallabpain pallabpain requested review from a team as code owners September 25, 2023 16:34
@pallabpain pallabpain self-assigned this Sep 25, 2023
@pallabpain pallabpain added the 🐛 bug Something isn't working label Sep 25, 2023
@github-actions
Copy link

🤖 Pull Request Artifacts (#6302230038) 🎉

@pallabpain pallabpain merged commit baa823d into devel Sep 26, 2023
7 checks passed
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/vpn-status branch October 1, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants