Open
Conversation
p-maxwell
reviewed
Apr 7, 2019
p-maxwell
left a comment
p-maxwell
left a comment
There was a problem hiding this comment.
Second one isn't quite right, but the first one is perfect.
| ); | ||
| }); | ||
|
|
||
| console.log(aliveOnly); |
| volume: 0, | ||
| fill: function() { | ||
| // calling this function should make you bottles volume = 100; | ||
| return (this.volume = this.volume + 100); // calling this function should make you bottles volume = 100; |
There was a problem hiding this comment.
You don't actually need to return anything here. More importantly though, this function will overfill the bottle - filling it to the top should leave it at 100, like 100%. If it's half full this takes it to 150...
| }, | ||
| drink: function() { | ||
| // calling this function should decrease your bottles volume by 10; | ||
| return (this.fill = this.fill - 10); // calling this function should decrease your bottles volume by 10; |
There was a problem hiding this comment.
Should use this.volume here, not this.fill. Again nothing needs to be returned.
| }, | ||
| empty: function() { | ||
| // this function should return true if your bottles volume = 0 | ||
| return (this.fill = this.volume); // this function should return true if your bottles volume = 0 |
There was a problem hiding this comment.
This won't work. How do you check the volume is zero?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.