Junaidr/refactor types #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Use types which are way clearer
+ Some docs
+ Use lens where they make things easier
+ New types required quite a significant factor of the codebase
+ TODO:
+ Cleanup
+ Further refactoring/polishing
+ I want type names to reflect those typically used when talking about simplex methods
+ But first, I need to learn what the actual terms are
+ I'd also like to simplify a lot of these functions
+ The refactor has made it easier for me to think about these functions, which makes it easier to simplify them
+ test10 was broken due to an LLM sneakily adding extra constraints and changing objective + testQuickCheck1/2 were broken because the constraints were built using `Map.fromList` with duplicate keys + only one of the key values were used, others were ignored
+ Control.Monad.Logger used for logging + Documented various functions + Handled some edge cases which shouldn't be possible (and log warnings/errors when we reach these edge cases)
+ I like this name better + Allows for alternative solvers
+ I was using the cabal plan as a key, now I use stack files/cabal generated files
+ Don't want to spend effor fixing windows caching
+ Fix bug with mergeBounds
+ And fix bug with findHighestVar
rasheedja
force-pushed
the
junaidr/refactor-types
branch
3 times, most recently
from
871d6ce to
75643ce
Compare
+ create new types for TermVarsOnly, ExprVarsOnly + Make Expr a non-empty list of terms + solver class for the future
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
75643ce to
f5ac83e
Compare
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
6973382 to
08340ff
Compare
- used after adding slack variables - realised I need to allow empty expressions to keep things simple - so refactored that, too - todo: tests for new functions
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
08340ff to
f9571d7
Compare
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
19e7f8c to
4a5579f
Compare
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
4a5579f to
7c44b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.