Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

add contact-form #277

Merged
merged 3 commits into from
Dec 13, 2024
Merged

add contact-form #277

merged 3 commits into from
Dec 13, 2024

Conversation

Agastya18
Copy link
Contributor

@Agastya18 Agastya18 commented Dec 12, 2024

Description

add contact form for the /contact route

Fixes Issue #274

Type of change

  • New feature
  • Feature Enhancement

Demo:

Screenshot 2024-12-12 at 11 11 50 PM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for personafm ready!

Name Link
🔨 Latest commit 3938fa0
🔍 Latest deploy log https://app.netlify.com/sites/personafm/deploys/675c91089b90070008bb4dad
😎 Deploy Preview https://deploy-preview-277.preview.personafm.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 29 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

deepsource-io bot commented Dec 12, 2024

Here's the code health analysis summary for commits ce31e27..3938fa0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 7 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@raspberri05
Copy link
Owner

Thanks for opening a pull request. Your pull request will be reviewed soon!

@raspberri05 raspberri05 linked an issue Dec 12, 2024 that may be closed by this pull request
@raspberri05 raspberri05 requested a review from Copilot December 12, 2024 19:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (5)
  • package.json: Language not supported
  • components/ui/textarea.tsx: Evaluated as low risk
  • components/ui/toast.tsx: Evaluated as low risk
  • components/ui/toaster.tsx: Evaluated as low risk
  • hooks/use-toast.ts: Evaluated as low risk
Copy link
Owner

@raspberri05 raspberri05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build had an error
image

After making the fixes you can also try building it locally with npm run build to see if the build errors were fixed. Also, what is the purpose of the Toaster component for?

@Agastya18
Copy link
Contributor Author

toaster for simple feedback to users in the form

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • package.json: Language not supported
  • components/ui/toast.tsx: Evaluated as low risk
  • components/ui/toaster.tsx: Evaluated as low risk
  • hooks/use-toast.ts: Evaluated as low risk
  • app/contact/layout.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)

components/contact.tsx:20

  • [nitpick] Using a hardcoded delay for form submission simulation is not ideal. Consider using a more flexible approach.
await new Promise((resolve) => setTimeout(resolve, 1000))

components/contact.tsx:15

  • The new form submission behavior is not covered by tests. Consider adding tests to cover this behavior.
async function onSubmit(event: React.FormEvent<HTMLFormElement>) {
Copy link
Owner

@raspberri05 raspberri05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request has been approved and will be merged shortly. Thanks for your contribution!
Please also consider starring this repository if you haven't already to allow more open source contributors to find this project.

@raspberri05 raspberri05 merged commit 686ac14 into raspberri05:main Dec 13, 2024
7 of 8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a contact form UI to the contact us page
2 participants