Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP client examples #385

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

peterharperuk
Copy link
Contributor

Examples to demonstrate HTTP, HTTPS and TLS validation Uses the lwip HTTP client

Fixes #318

@peterharperuk peterharperuk added this to the 1.5.1 milestone May 17, 2023
@peterharperuk peterharperuk requested a review from kilograham May 17, 2023 17:50
@peterharperuk peterharperuk modified the milestones: 1.5.1, 1.6.0 May 26, 2023
@peterharperuk
Copy link
Contributor Author

Needs raspberrypi/pico-sdk#1388

@lurch
Copy link
Contributor

lurch commented May 29, 2023

I guess this PR should probably update https://github.com/raspberrypi/pico-examples/blob/develop/README.md too?

EDIT: done

@peterharperuk
Copy link
Contributor Author

Depends on #460

@lurch
Copy link
Contributor

lurch commented Mar 13, 2024

Should this be "rebased" on top of #475 , or will #475 get updated after this PR has been merged? (or am I barking up entirely the wrong tree? 😆 )

@peterharperuk
Copy link
Contributor Author

Oops, yes you're right. I'll fix that. GitHub doesn't seem to handle dependencies between PR's but I can assume it's merged first

@hasenradball
Copy link

@peterharperuk
Hi Peter,

got some error during compile.
missing some file.

[build]                  from /home/frank/Dokumente/Pi_Pico_C++_SDK/pico/pico-examples/pico_w/wifi/http_client/picow_http_client.c:11:
[build] /home/frank/Dokumente/Pi_Pico_C++_SDK/pico/pico-examples/pico_w/wifi/http_client/mbedtls_config.h:4:10: fatal error: mbedtls_config_examples_common.h: No such file or directory
[build]     4 | #include "mbedtls_config_examples_common.h"
[build]       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@peterharperuk
Copy link
Contributor Author

peterharperuk commented Jul 2, 2024

It needs to be rebased on the tip of develop where that file exists. I've done this and pushed an update with conflicts resolved.

@hasenradball
Copy link

hasenradball commented Jul 6, 2024

@peterharperuk
Hi Peter,

some hint to your example I would add the LEDas indicator to show if test is active or finished.

  • Just switch on LED at beginning.

  • Switch off when test is passed.

  • Maybee let led blink when no connection is possible.

So you see directly at the LED whats going on.

@lurch
Copy link
Contributor

lurch commented Jul 7, 2024

I think that this example (like all the other examples in this repo) assumes that you're able to see the printf outputs. See Chapter 4 of https://datasheets.raspberrypi.com/pico/getting-started-with-pico.pdf

@peterharperuk
Copy link
Contributor Author

I also think this would be confusing as the example gives you the ability to switch the led on and off.

@peterharperuk peterharperuk modified the milestones: 1.5.2, 1.6.0 Jul 22, 2024
@kilograham kilograham modified the milestones: 1.6.0, 2.0.1 Aug 20, 2024
@kilograham
Copy link
Contributor

seems like this needs rebasing

Examples to demonstrate HTTP, HTTPS and TLS validation

Fixes raspberrypi#318
@peterharperuk peterharperuk marked this pull request as draft November 22, 2024 20:13
@peterharperuk peterharperuk marked this pull request as ready for review November 22, 2024 20:55
@peterharperuk
Copy link
Contributor Author

@kilograham ok, this could perhaps be merged now.

README.md Outdated Show resolved Hide resolved
@kilograham kilograham merged commit 3fc5ce7 into raspberrypi:develop Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants