Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip encrypted bootloader with no mbedtls #522

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

will-v-pi
Copy link
Contributor

Currently, a pico-examples build without the mbedtls submodule checked out in the SDK will fail, as picotool throws

ERROR: Cannot sign/hash partition table with no mbedtls

when making enc_bootloader, due to being compiled without mbedtls

Solve this by skipping enc_bootloader when there is no pico_mbedtls

@will-v-pi will-v-pi requested a review from lurch August 20, 2024 13:09
@kilograham
Copy link
Contributor

small nit, but the convention is to put the guard in the individual example's CMakeLists.txt unless it affects multiple examples

Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example now gets correctly skipped inside a Docker image where I've cloned pico-sdk but not init-ed its submodules

@will-v-pi
Copy link
Contributor Author

small nit, but the convention is to put the guard in the individual example's CMakeLists.txt unless it affects multiple examples

This will probably end up applying to multiple bootloader examples in the long run, so I think it's ok? It applies to anything that requires signing/hashing with picotool

@kilograham kilograham merged commit 724236a into raspberrypi:develop Aug 21, 2024
1 check passed
@will-v-pi will-v-pi deleted the enc-no-mbedtls branch October 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants