Fix SSD1306 example to display all text on small (32px) screens #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Aug 24, 2024
|
accidentally closed the pr by deleting my local branch, re-opening |
|
Also, can you change the base branch to |
kaycebasques
force-pushed
the
ssd1306-fix
branch
from
e0d8b62 to
5932b77
Compare
lurch
reviewed
Sep 1, 2024
lurch
reviewed
Sep 1, 2024
kaycebasques
commented
Sep 2, 2024
| // Height limit reached. Show some lines. | ||
| if (y == SSD1306_HEIGHT) { | ||
| render(buf, &frame_area); | ||
| sleep_ms(3000); |
There was a problem hiding this comment.
So what happens when you run this app is:
- Lines 0 to 3 get printed ("a long time ago on an oled display far far away")
- Wait 3s (this the sleep on 398)
- Lines 4 to 7 get printed ("live a small red raspberry by the name of PICO")
- Wait 3s (again the sleep on 398)
- The extra check on lines 404 to 407 doesn't run with the default text because y is reset to 0
- Wait another 3s (this is the extra sleep on line 409 we should remove)
Leaving the sleep on line 398 and 406 ensures that text always displays for exactly 3s
|
I don't have a SSD1306 with which to test, but the code looks fairly plausible. Thanks for incorporating all my feedback @kaycebasques ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last 4 lines of
textare never displayed on the 32px-tall versions of SSD1306. This PR makes sure all oftextis always displayed (at the cost of making the logic a bit more complex).