Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdio_set_chars_available_callback for usb #1649

Merged

Conversation

peterharperuk
Copy link
Contributor

When you get a callback to tell you a character is available, you should be able to call getchar_timeout_us, but it's not working for USB

Fixes #1603

Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you lost the PICO_STDIO_USB_SUPPORT_CHARS_AVAILABLE_CALLBACK protection.

@peterharperuk
Copy link
Contributor Author

Fixed. Messy.

When you get a callback to tell you a character is available, you should
be able to call getchar_timeout_us, but it's not working for USB

Fixes raspberrypi#1603

Co-authored-by: Andrew Gordon <arg@gordondesign.ltd.uk>
@kilograham kilograham merged commit ac8f277 into raspberrypi:develop May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants