-
Notifications
You must be signed in to change notification settings - Fork 1.1k
pico_flash: Support FreeRTOS Static Allocation #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like this might be a nicer alternative
|
One thing I want to get your thoughts on (and sorry for the couple days of delay here): would it be better to default to static allocation and only switch to dynamic if static allocation isn't enabled? |
For some reason I skipped that — I can switch to it and let you know if it compiles. Unfortunately I don't really have any way to make sure that things still work besides compiling. |
compiling is better than me as I don't have a config with this setup, so would have to make one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so this isn't ideal as it will likely crash if flash_safe_execute()
is called from both cores concurrently in this case.. I am approving anyway, because
a) This does compile and likely works correctly when not doing that
b) That use case is probably unlikely
c) Arguably the existing implementation is not very robust in that regard, so I will open a separate issue
Fixes #2120
Allows
pico_flash
to use FreeRTOS static allocation as currently static-only builds fail without this change.