Improve 4Kn support #104
Open
Improve 4Kn support #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capacity validator allowed suffixed values (e.g. "4K"), but mkfs.vfat -S accepts only plain digits, causing failures. Restrict sector_size to numeric values (512 or 4096) and update the description to define it as the target device's logical sector size, with context on 512n/512e/4Kn.
mkfs.vfat already uses IGconf_device_sector_size, but try to encourage mkfs.ext4 to use a minimum block size of 4K if this variable specifies a 4K sector size. No change to BTFS filesystem creation.
|
Hi @martamomotko @timg236 @roliver-rpi The only functional difference here is if
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves handling of the config variable that defines the target device storage sector size (basically now enforces 512 or 4096)
Encourages mkfs.ext4 to use a minimum block size of 4K if that variable indicates a 4Kn device.