fix dynamic properties PHP 8.2 #1004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krajcikondra The test suite doesn't execute the tests with PHP 8.2 currently and we can't see if your changes are completely fixing the issue, but I am looking into that, see #1003 for more details. Once I get everything updated, we can come back to this one. Depending on how far I go with #1003, I might need to apply the same changes as you did, I'll keep you posted 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
on php 8.2 I get errors like this:
Deprecated: Creation of dynamic property Ratchet\Server\IoConnection::$httpBuffer is deprecated