Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update GitHub CI badges #358

Merged
merged 1 commit into from
Nov 29, 2024
Merged

README: update GitHub CI badges #358

merged 1 commit into from
Nov 29, 2024

Conversation

hnez
Copy link
Contributor

@hnez hnez commented Nov 29, 2024

The previous badge pointed to the meta-rauc.yml workflow file, which is no longer used in any branch.
Instead the workflow now resides in build.yml in all branches.

Daily scheduled builds are triggered from schedule-builds.yml via workflow_dispatch for all branches.
Display the status of the most recent workflow_dispatch build for all currently supported branches.

We should likely include the release name in the respective build.yml for each branch so it is shown in the badge.

@ejoerns
Copy link
Member

ejoerns commented Nov 29, 2024

We should likely include the release name in the respective build.yml for each branch so it is shown in the badge.

Indeed, having the same badge four times looks a little odd. As branch names or customizing the badge does not seem to be supported, I'd also tend to include the branch/release name in the build.yml's name.

@ejoerns ejoerns added the master label Nov 29, 2024
@hnez
Copy link
Contributor Author

hnez commented Nov 29, 2024

I've just opened another pull request that does basically the same in meta-ptx pengutronix/meta-ptx#166 but with the release names set in the build.yml's name field.
We can experiment there first to find out if we like the look.

The previous badge pointed to the `meta-rauc.yml` workflow file,
which is no longer used in any branch.
Instead the workflow now resides in `build.yml` in all branches.

Daily scheduled builds are triggered from `schedule-builds.yml` via
`workflow_dispatch` for all branches.
Display the status of the most recent `workflow_dispatch` build for all
currently supported branches.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez
Copy link
Contributor Author

hnez commented Nov 29, 2024

Setting the name field did not work out quite like I wanted it to.

I've instead experimented with using a table to display the different build status: README.

What do you think?

Copy link
Member

@ejoerns ejoerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, it looks like a good compromise if the alternatives just don't work.

@ejoerns ejoerns requested a review from jluebbe November 29, 2024 13:03
@hnez hnez merged commit d8a9839 into rauc:master Nov 29, 2024
2 checks passed
@hnez hnez deleted the ci-badges branch November 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants