Add .gitattributes, unify eol/encoding

[Repiteo]

Implements a basic .gitattributes to further ensure lf as the repository encoding. Additionally touched a handful of files that weren't using lf/utf8 as expected.

[raulsntos]

Thanks. Looks like Visual Studio may need the .sln file to use UTF-8 with BOM¹. Not sure if this also applies to the .csproj files, and I don't use Visual Studio. Otherwise, the changes look good to me.

Footnotes

1. https://github.com/dotnet/sdk/issues/8929 ↩

[Repiteo]

Now that you mention it, .csproj and .sln are indeed likely exceptions. To play it safe, I'll set them both up with crlf/utf-8-bom & have .gitattributes/.editorconfig reflect that.

[raulsntos]

Can you revert the GUID changes to Godot.sln (as discussed in godotengine/godot#91479 (comment))? Then it should be good to merge, thanks!

[Repiteo]

Somehow missed that I never got that fix in, whoops. Well, better late than never!

[raulsntos]

It looks like the tests are failing on Windows because it expects CRLF endings in the generated .cs files for some reason. I don't know why changing the line endings in the .csproj/.sln would affect this though.

[Repiteo]

The easiest workaround I could find was ensuring the generated files use \n line endings.

[raulsntos]

That doesn't explain why the tests were passing before. Could it be that .gitattributes determines what line endings the cloned files will have? If so, I guess CI was cloning these files with CRLF before since it was unspecified.

I wonder if we could have the generator tests ignore line endings instead when comparing.

[Repiteo]

I believe the default checkout behavior for Git on Windows has autocrlf=true, which would make all unspecified files have \r\n eol. Making them explicitly lf has the benefit of ensuring that crlf can't be passed to the repo itself, but it causes weird edge-cases on Windows for some Microsoft tools.

In any case, I applied the changes to the generator tests instead. Now after reading the files it converts the line endings to System.Environment.NewLine, effectively making them ignored when compared. There might be a more efficient way of pulling this off, but it got the job done.

[raulsntos]

In any case, I applied the changes to the generator tests instead. Now after reading the files it converts the line endings to System.Environment.NewLine, effectively making them ignored when compared.

That seems like the recommended approach¹ so it works for me 👍

Footnotes

1. https://github.com/dotnet/roslyn-sdk/issues/983#issuecomment-1130623676 ↩

[raulsntos]

Thanks!