fix(rune): Correct build logic for rune module #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! Could you remove the unrelated changes? Also the right fix would be to add an effect for qr (and the other operations that are currently failing) |
ColonelToad
force-pushed
the
fix/rune-build-logic
branch
from
347baed to
f33ae97
Compare
Author
|
Got it, fixed both issues now |
Contributor
|
I don't see your changes for
|
ColonelToad
force-pushed
the
fix/rune-build-logic
branch
from
f33ae97 to
dff2c66
Compare
Author
|
Sorry about that, my last commit on cleaned up how many files were added but didn't include the new changes to nx_rune, that should be there now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix for issue #133