Introduce a new structure to represent package requirements #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With that change, the previous PackageRequirement structure was renamed to SoftPackageRequirement, and the new structure took its original name.
doom
commented
Aug 15, 2019
| @@ -38,16 +38,16 @@ impl PackageRequirement { | |||
|
|
|||
| /// Creates a package requirement that matches the given [`PackageFullName`] and version requirement. | |||
| #[inline] | |||
| pub fn from_id(id: &PackageID) -> PackageRequirement { | |||
| PackageRequirement { | |||
| pub fn from_id(id: &PackageID) -> SoftPackageRequirement { | |||
There was a problem hiding this comment.
This somehow wasn't implemented as a From<PackageID>, I opened an issue for it: see #100
doom
commented
Aug 15, 2019
|
|
||
| /// Creates a package requirement that matches the given [`PackageFullName`] and version requirement. | ||
| #[inline] | ||
| pub fn from_id(id: &PackageID) -> PackageRequirement { |
There was a problem hiding this comment.
This somehow wasn't implemented as a From<PackageID> for SoftPackageRequirement, I opened an issue for it: see #100
Arignir
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With that change, the previous PackageRequirement structure was renamed to SoftPackageRequirement, and the new structure took its original name.