Skip to content

Conversation

@OmarGamal10
Copy link
Collaborator

  • Fixes: for-you feed would show tweets from people you block for some time.
  • The fix: separate validation of tweet based on its source, tweets from followings check still following (includes non-blocked), non-muted, and non-deleted author, while tweets from interests check against non-muted, non-blocked, and non-deleted (interest tweets will, of course, be from people you don't follow)

@github-actions
Copy link

Testers Checklist

General

  • Validation for every input
  • Persistent try/catch blocks
  • No lack of documentation
  • Localization

Backend

  • Standard response
  • Sanitization for all user input data
  • Queries transactions for rollbacks
  • Idempotency
  • Monitoring & Logging
  • Filtering and Pagination
  • Documentation is updated correctly
  • Stateless design
  • OpenAPI spec is correctly updated and synced to other teams
  • Designing indexes (if applicable)
  • Rate limiting (if applicable)
  • Soft deleting (if applicable)

@OmarGamal10 OmarGamal10 changed the title fix: differentiate validation of following authors from interest authors fix: differentiate validation of following authors from interest authors - [CU-869bfnxa6] Dec 13, 2025
@OmarGamal10
Copy link
Collaborator Author

@github-actions
Copy link

OpenAPI Diff Report for openapi

OpenAPI Compatibility Report

Compared Specs: openapi - openapi
Report Result: NoChanges

Added Endpoints

Removed Endpoints

Deprecated Endpoints

Changed Endpoints


@github-actions github-actions bot added OAS:NoChanges No OpenAPI Specification changes and removed OAS:NoChanges No OpenAPI Specification changes labels Dec 13, 2025
@github-actions github-actions bot added OAS:NoChanges No OpenAPI Specification changes and removed OAS:NoChanges No OpenAPI Specification changes labels Dec 15, 2025
@github-actions
Copy link

Unit Tests Coverage Report

Coverage after merging fix/for-you-stale-blocking-authors into dev will be
66.31%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/tweets/timeline
   timeline.service.ts2.18%3.54%0%1.73%1003–1005, 1008–1009, 1009, 1009, 1009, 1009–1010, 1015, 1015, 1015–1017, 1017, 1017–1020, 1023, 1025, 1025, 1025–1027, 1030, 1030, 1039–1040, 1043, 1043, 1043–1046, 1050–1053, 1053, 1058, 1068, 1068, 1068, 1070–1071, 1071, 1071–1072, 1072, 1072, 1072, 1072–1073, 1078–1079, 1079, 1079–1080, 1082, 1086, 1097–1101, 1103–1104, 1104, 1104, 1108, 1111–1112, 1112, 1112–1113, 1117–1118, 1120, 1122, 1125–1127, 1127, 1127–1129, 1132, 1136, 1136, 1136, 1138–1140, 1140, 1140–1141, 1147, 1152, 1155, 1157–1158, 1160–1161, 1165, 1168–1170, 1170, 1170–1171, 1175, 1175, 1175, 1177, 1179–1180, 1182–1183, 1186, 1188, 119, 1196, 1199, 1199, 1199–1200, 1203, 1206, 1218, 122, 1220–1221, 1226–1227, 1229, 1229, 1229, 123, 123, 123, 1231, 1234, 1234, 1234, 1236, 124, 1241–1243, 1245, 125, 1251, 1251, 1251, 1254, 1257, 126, 1261–1262, 1264–1265, 1265, 1265–1266, 1270–1271, 1273, 1273, 1273–1274, 1277–1278, 1280–1281, 1283–1284, 1287, 129, 1293, 1295–1296, 1298–1299, 1299, 1299, 130, 1302, 1306, 1306, 1306–1307, 131, 1311–1312, 1315–1316, 1318–1319, 132, 1320–1321, 1323, 1326–1327, 1329, 1329, 1329, 133, 1330–1332, 1334, 1337–1339, 1339, 1339, 1339, 1339–1340, 1343, 1349, 135, 135, 135, 1350, 1350, 1350–1351, 1354, 1357–1359, 136, 1362–1364, 1371, 1375, 138, 1381, 1383, 1383, 1383–1384, 1384, 1384, 1389, 1393, 1401–1402, 1402, 1402–1408, 1413, 1413, 1413, 1413, 1413–1414, 1417, 1420, 144, 144, 144, 144, 144–145, 148, 150, 155, 157–158, 160–163, 165, 165, 165, 165, 165, 167, 167, 167, 167, 170, 172, 176, 176, 176–177, 181, 185, 190, 192–193, 196–197, 200, 202, 204–207, 207, 207–208, 213, 215–216, 219–220, 223, 225, 238, 241, 241, 241, 241, 241–245, 245, 245, 252, 256, 266–267, 267, 267, 269, 269, 269, 269, 269–270, 279, 279, 279, 279, 279–280, 285, 290–291, 291, 291, 291, 291–294, 297, 308–309, 31, 310–313, 316, 318, 320–321, 323–324, 330–331, 337, 342, 342, 342, 342, 342–344, 349, 35, 35, 35, 352, 355, 357, 357, 357, 359, 36, 36, 368–369, 37, 371–372, 372, 372, 372, 372–374, 374, 374–376, 380–381, 381, 381, 381, 381–383, 383, 383–385, 389, 389, 389, 39, 390–391, 391, 391, 391, 391–393, 393, 393–394, 397, 402, 406, 427, 427, 427, 427, 427–428, 43, 434, 439, 441–442, 45, 450–451, 459, 46, 46, 46, 461, 47, 477–479, 48, 480, 482–484, 486, 488–489, 49, 49, 49, 49, 49, 494, 499, 50, 506, 508, 508, 508, 510, 519–520, 526, 528, 528, 528, 528, 528–529, 53, 531, 534, 534, 534, 534, 534–535, 537, 540, 540, 540, 540, 540–541, 543, 547, 552, 558, 558, 558–559, 567, 572, 595, 597, 599–601, 608–609, 616–617, 625, 636–639, 64, 641–644, 651, 653, 653, 653, 655, 661–664, 666, 666, 666–668, 67, 67, 67, 671, 671, 671, 671, 671–674, 676, 68, 680, 685–686, 688–690, 696<

@github-actions github-actions bot added OAS:NoChanges No OpenAPI Specification changes and removed OAS:NoChanges No OpenAPI Specification changes labels Dec 15, 2025
@galelo04 galelo04 merged commit e5e3592 into dev Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OAS:NoChanges No OpenAPI Specification changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants