Skip to content

test: notifications - [CU-869bggmjy]#228

Merged
anas-ibrahem merged 6 commits intodevfrom
test/notifications
Dec 15, 2025
Merged

test: notifications - [CU-869bggmjy]#228
anas-ibrahem merged 6 commits intodevfrom
test/notifications

Conversation

@galelo04
Copy link
Member

No description provided.

@OmarGamal10
Copy link
Collaborator

Task linked: CU-869bggmjy unit test notifications

AhmedSobhy01
AhmedSobhy01 previously approved these changes Dec 15, 2025
@raven-swe raven-swe deleted a comment from github-actions bot Dec 15, 2025
anas-ibrahem
anas-ibrahem previously approved these changes Dec 15, 2025
@raven-swe raven-swe deleted a comment from github-actions bot Dec 15, 2025
@github-actions
Copy link

Testers Checklist

General

  • Validation for every input
  • Persistent try/catch blocks
  • No lack of documentation
  • Localization

Backend

  • Standard response
  • Sanitization for all user input data
  • Queries transactions for rollbacks
  • Idempotency
  • Monitoring & Logging
  • Filtering and Pagination
  • Documentation is updated correctly
  • Stateless design
  • OpenAPI spec is correctly updated and synced to other teams
  • Designing indexes (if applicable)
  • Rate limiting (if applicable)
  • Soft deleting (if applicable)

@github-actions
Copy link

Unit Tests Coverage Report

Coverage after merging test/notifications into dev will be
94.22%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/common/utils
   cursor-pagination.util.ts97.44%91.67%100%100%29
src/notifications/utils
   fcm-notification-body-builder.ts81.33%73.50%60%89.92%101, 103, 105, 133, 137, 144, 152, 156, 179, 191, 196–197, 208, 208, 211, 216–218, 218, 218, 230–231, 231, 46, 56, 61, 61, 61, 61, 61–62, 62, 62–63, 63, 63, 63, 63–65, 67, 85, 95

@github-actions
Copy link

OpenAPI Diff Report for openapi

OpenAPI Compatibility Report

Compared Specs: openapi - openapi
Report Result: NoChanges

Added Endpoints

Removed Endpoints

Deprecated Endpoints

Changed Endpoints


@github-actions github-actions bot added the OAS:NoChanges No OpenAPI Specification changes label Dec 15, 2025
@anas-ibrahem anas-ibrahem merged commit 11c935b into dev Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OAS:NoChanges No OpenAPI Specification changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants