feat: add initial nginx and docker compose files - [CU-869b1p50h] #10
+369
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoayAhmed304
requested review from
AhmedSobhy01,
AmrSamy59 and
im-saif
as code owners
Member
Author
|
Task linked: CU-869b1p50h Push config files |
AhmedSobhy01
requested changes
Nov 3, 2025
| location / { | ||
| proxy_pass http://127.0.0.1:8000; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $http_x_real_ip; |
Member
There was a problem hiding this comment.
This is a header and it can be empty .. make same like as production to be remote_addr
| proxy_pass http://127.0.0.1:8000; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $http_x_real_ip; | ||
| proxy_set_header X-Forwarded-For $http_x_real_ip; |
Member
Author
There was a problem hiding this comment.
This is an attempt to forward the header that the frontend will set
AhmedSobhy01
requested changes
Nov 3, 2025
LoayAhmed304
force-pushed
the
feat/compose-nginx-files
branch
from
7324d77 to
4c94b9d
Compare
AhmedSobhy01
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that staging nginx config file is the latest one, the production is not touched for a while now