Fix RLMLogger import path — logging silently broken#3
Open
timothyjlaurent wants to merge 1 commit intorawwerks:masterfrom
Open
Fix RLMLogger import path — logging silently broken#3timothyjlaurent wants to merge 1 commit intorawwerks:masterfrom
timothyjlaurent wants to merge 1 commit intorawwerks:masterfrom
Conversation
`from rlm import RLMLogger` fails silently because RLMLogger is not exported from the top-level rlm package. The correct import is `from rlm.logger import RLMLogger`. This caused --log-dir and output.log_dir config to have no effect, since _maybe_logger() swallows the ImportError. Fixes rawwerks#2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from rlm import RLMLogger→from rlm.logger import RLMLoggerinrlm_adapter.pyRLMLoggeris not exported from the top-levelrlmpackage, so the import silently fails inside_maybe_logger()'s bareexcept Exception--log-dirandoutput.log_dirconfig have no effect — no log files are ever createdTest plan
from rlm.logger import RLMLoggerworks.jsonllog files are now created in the configuredlog_dirFixes #2
🤖 Generated with Claude Code