Validate tmp directory #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #209 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 168 168
===========================================
Files 30 30
Lines 470 470
===========================================
Hits 470 470 ☔ View full report in Codecov by Sentry. |
koriym
force-pushed
the
validate-tmp-dir
branch
from
82e3664
to
9ce7f91
Compare
momospnr
reviewed
Jan 15, 2024
sl-src/Cache.php
Outdated
| if (! is_writable($dir)) { | ||
| mkdir($dir, 0777, true); | ||
| } | ||
| if (! is_dir($dir) && ! @mkdir($dir) && ! is_dir($dir) && ! is_writable($dir)) { |
There was a problem hiding this comment.
パーミッションの付与も必要かと思いました。
! @mkdir mkdir($dir, 0777, true)
There was a problem hiding this comment.
mkdirのデフォルトのパーミッションは777です。
https://www.php.net/manual/en/function.mkdir.php
There was a problem hiding this comment.
マニュアル見ずにコメントしちゃってすみません！
デフォルトで 0777 なんですね。
失礼しました🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.