Skip to content

Conversation

@ryanaoleary
Copy link
Collaborator

Why are these changes needed?

Implement rollback support for the IncrementalUpgrade RayService feature.

Related issue number

#3209

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

ryanaoleary and others added 29 commits September 16, 2025 09:57
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Update go mod dependencies for gateway v1

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add reconcile Gateway and HTTPRoute

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add TargetCapacity and TrafficRoutedPercent to RayServiceStatus

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add controller logic initial commit

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add IncrementalUpgrade check to ShouldUpdate

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Update controller logic to reconcile incremental upgrade

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

TrafficRoutedPercent should not set default value

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Remove test changes to TPU manifest

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Move helper function to utils

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix lint

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix field alignment

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix bad merge

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix CRDs and add validation test case

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Test create HTTPRoute and create Gateway

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add reconcile tests for Gateway and HTTPRoute

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix lint

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add tests for util functions and fix golangci-lint

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add basic e2e test case

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix GetGatewayListeners logic and test

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add gatewayv1 scheme to util runtime

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Check if IncrementalUpgrade is enabled before checking Gateway

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix reconcile logic for Gateway and HTTPRoute

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add feature gate

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Always create Gateway and HTTPRoute for IncrementalUpgrade

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Fix target_capacity reonciliation logic

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Add additional unit tests

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>

Move e2e test and add another unit test

Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary
Copy link
Collaborator Author

cc: @Future-Outlier the changes for full rollback support are just in this commit: f5d0243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant