[e2e] RayJob Auth Mode E2E #4229
Conversation
Signed-off-by: seanlaii <qazwsx0939059006@gmail.com>
seanlaii
force-pushed
the
rayjob-auth-e2e
branch
from
f5c06a1 to
fabaf58
Compare
|
Hi @Future-Outlier @rueian , please help review the PR when you have the chance. Thank you! |
| VerifyContainerAuthTokenEnvVars(test, rayCluster, &workerPod, utils.RayContainerIndex) | ||
| } | ||
|
|
||
| // TODO(andrewsykim): add job submission test with and without token once a Ray version with token support is released. |
There was a problem hiding this comment.
Can we open a issue to track this? I think we can find someone to pick it up.
There was a problem hiding this comment.
Sure, I can also create a PR to add it. The supported Ray version has been released. I will create another PR to address this. WDYT?
There was a problem hiding this comment.
Separate PR is fine. We can also probably just remove this given the submission is also exercised with RayJob
| VerifyContainerAuthTokenEnvVars(test, rayCluster, &workerPod, utils.RayContainerIndex) | ||
| } | ||
|
|
||
| // TODO(andrewsykim): add job submission test with and without token once a Ray version with token support is released. |
400Ping
left a comment
400Ping
left a comment
There was a problem hiding this comment.
Besides needing to fix the CI, overall LGTM.
| VerifyContainerAuthTokenEnvVars(test, rayCluster, &workerPod, utils.RayContainerIndex) | ||
| } | ||
|
|
||
| // TODO(andrewsykim): add job submission test with and without token once a Ray version with token support is released. |
There was a problem hiding this comment.
Separate PR is fine. We can also probably just remove this given the submission is also exercised with RayJob
ray-operator/test/support/ray.go
Outdated
| t.T().Helper() | ||
| g := NewWithT(t.T()) | ||
|
|
||
| g.Expect(len(pod.Spec.Containers)).To(BeNumerically(">", containerIndex), |
There was a problem hiding this comment.
I think we can remove this assertion and thecontainerIndex parameter, and instead just pass in corev1.Container.
There was a problem hiding this comment.
Sure, thanks for the review! Updated the tests accordingly.
Thanks, fixed the issue. |
4 participants
Why are these changes needed?
This PR adds comprehensive E2E tests for Ray authentication token mode to ensure correct auth token propagation across three RayJob submission modes:
Related issue number
Part of #4203
Checks