Introduce historyserver directory and project structure #4232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@KunWuLuan PTAL, this is a PR just to introduce project folders. Ideally we can open a separate PR per folder based on the PR you already have open: #4187 |
andrewsykim
force-pushed
the
history-server-setup
branch
3 times, most recently
from
3d8223e to
3fd4a41
Compare
Contributor
|
Thanks, I think this is very helpful when reviewing. |
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
force-pushed
the
history-server-setup
branch
from
3fd4a41 to
b47bffb
Compare
rueian
approved these changes
Nov 27, 2025
400Ping
approved these changes
Nov 27, 2025
Future-Outlier
approved these changes
Nov 27, 2025
| @@ -0,0 +1 @@ | |||
| package eventserver | |||
Member
There was a problem hiding this comment.
will event collector be a better name?
I am ok with both
Member
There was a problem hiding this comment.
maybe we can merge this first, and @KunWuLuan can change the directory and project structure if they want?
Member
Author
There was a problem hiding this comment.
eventserver is different from collector. @chiayi is working on a POC of how to process events from storage into server-side state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is based on #4187 and introduces high level project structure for history server. Mainly opening this PR to make it easier to break up #4187 into smaller reviewable PRs
Related issue number
Checks