[kubectl-plugin][Test] Use client-go reactors for FieldSelector filtering in fake client tests #4361

ikchifo · 2026-01-09T19:35:21Z

Why are these changes needed?

NewSimpleClientset and its successor NewClientset do not support FieldSelector filtering for List operations in unit tests. Tests currently rely on manual name checking as a workaround, which diverges from real Kubernetes API server behavior.

This PR adds client-go reactors to simulate server-side FieldSelector filtering, making fake client behavior match the real Kubernetes API more closely.

Before

Tests manually filter results after List calls:

for _, rayCluster := range rayClusterList.Items {
    if cluster != "" && rayCluster.Name != cluster {
        continue
    }

After

Reactor handles filtering automatically, matching real API behavior. Manual workarounds removed.

What did I do?

Created AddRayClusterFieldSelectorReactor helper in pkg/util/client/testing/reactor.go
Applied reactor to completion_test.go and get_cluster_test.go
Removed manual name filtering workaround from completion.go
Migrated 6 test files from deprecated NewSimpleClientset to NewClientset

Related issue number

Closes #4337

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

cc @justinyeh1995 @CheyuWu @rueian

…t tests Add AddRayClusterFieldSelectorReactor helper that simulates server-side FieldSelector filtering in fake client tests. This addresses issue ray-project#4337 by allowing tests to verify filtering behavior without manual name checks. Refs: ray-project#4337

Use the new AddRayClusterFieldSelectorReactor in workergroup completion tests to properly simulate server-side filtering behavior. Refs: ray-project#4337

Remove the workaround that manually filtered clusters by name since the fake client now properly supports FieldSelector filtering via reactors. Refs: ray-project#4337

NewSimpleClientset is deprecated in favor of NewClientset for better server-side apply testing support. Note: scale_cluster_test.go is not migrated because it uses Update operations that require schema definitions missing from the generated applyconfiguration internal schema. Refs: ray-project#4337

justinyeh1995

Hi @ikchifo, would you mind helping update
kubectl-plugin/pkg/cmd/scale/scale_cluster_test.go as well?

justinyeh1995 · 2026-01-10T11:29:26Z

Manual test looks good to me with

pushd kubectl-plugin > /dev/null
go build cmd/kubectl-ray.go
mv kubectl-ray ~/.krew/bin
popd > /dev/null
export PATH=$PATH:$HOME/.kubectl-plugin-completion

kubectl-plugin/pkg/util/client/testing/reactor.go

kubectl-plugin/pkg/util/completion/completion_test.go

ikchifo · 2026-01-10T12:15:14Z

Hi @ikchifo, would you mind helping update kubectl-plugin/pkg/cmd/scale/scale_cluster_test.go as well?

@justinyeh1995 Investigated this - and couldn't migrate scale_cluster_test.go as is because it uses Update() operations, and NewClientset requires Server-Side Apply schemas that aren't generated for RayCluster.
Reactors can't bypass this since validation happens before they're invoked. We would need changes in ray-operator's codegen to fix it.

schema error: no type found matching: com.github.ray-project.kuberay.ray-operator.apis.ray.v1.RayCluster

…t setup Add a convenience wrapper that creates a fake Ray clientset with FieldSelector reactor pre-configured. This simplifies test setup and ensures consistent behavior across tests. Also applies reactor to get_cluster_test.go and fixes test data to match actual cluster names now that FieldSelector properly filters. Refs: ray-project#4337

Co-authored-by: JustinYeh <justinyeh1995@gmail.com> Signed-off-by: Ikenna <ikennachifo@gmail.com>

justinyeh1995 · 2026-01-10T14:56:18Z

Hi @ikchifo, would you mind helping update kubectl-plugin/pkg/cmd/scale/scale_cluster_test.go as well?

@justinyeh1995 Investigated this - and couldn't migrate scale_cluster_test.go as is because it uses Update() operations, and NewClientset requires Server-Side Apply schemas that aren't generated for RayCluster. Reactors can't bypass this since validation happens before they're invoked. We would need changes in ray-operator's codegen to fix it.
schema error: no type found matching: com.github.ray-project.kuberay.ray-operator.apis.ray.v1.RayCluster

Thanks for the investigation. I am fine with leaving it as-is for now.

justinyeh1995 · 2026-01-10T14:58:32Z

cc @machichima for another pass of review if you still have bandwidth. Thanks.

Update clientset.go and reactor_test.go to use the renamed function AddRayClusterListFieldSelectorReactor.

justinyeh1995

LGTM, unit tests and manual test passed as well. Thanks!

Future-Outlier · 2026-01-12T13:28:47Z

kubectl-plugin/pkg/util/completion/completion.go

-		if cluster != "" && rayCluster.Name != cluster {
-			continue
-		}


why delete this line??

cc @cheyu @lorriexingfang @Jiekai for review

ah since we use field selector now

ikchifo added 4 commits January 9, 2026 13:51

test(kubectl-plugin): apply FieldSelector reactor to completion tests

eada581

Use the new AddRayClusterFieldSelectorReactor in workergroup completion tests to properly simulate server-side filtering behavior. Refs: ray-project#4337

refactor(kubectl-plugin): remove manual name filtering in completion

464f138

Remove the workaround that manually filtered clusters by name since the fake client now properly supports FieldSelector filtering via reactors. Refs: ray-project#4337

ikchifo mentioned this pull request Jan 9, 2026

[kubectl-plugin][Test] Use client-go reactors to support FieldSelector filtering in fake client tests #4337

Closed

2 tasks

justinyeh1995 reviewed Jan 10, 2026

View reviewed changes

kubectl-plugin/pkg/util/client/testing/reactor.go Outdated Show resolved Hide resolved

justinyeh1995 reviewed Jan 10, 2026

View reviewed changes

kubectl-plugin/pkg/util/completion/completion_test.go Outdated Show resolved Hide resolved

ikchifo and others added 2 commits January 10, 2026 07:25

Update kubectl-plugin/pkg/util/client/testing/reactor.go

2e4d4d4

Co-authored-by: JustinYeh <justinyeh1995@gmail.com> Signed-off-by: Ikenna <ikennachifo@gmail.com>

ikchifo force-pushed the kubectl-plugin/fieldselector-reactor-tests branch from df9ad48 to f3df8bc Compare January 10, 2026 12:30

CheyuWu self-requested a review January 10, 2026 16:37

fix(kubectl-plugin): update references to renamed reactor function

e5fdf04

Update clientset.go and reactor_test.go to use the renamed function AddRayClusterListFieldSelectorReactor.

ikchifo force-pushed the kubectl-plugin/fieldselector-reactor-tests branch from f3df8bc to e5fdf04 Compare January 10, 2026 20:37

justinyeh1995 approved these changes Jan 11, 2026

View reviewed changes

Future-Outlier reviewed Jan 12, 2026

View reviewed changes

Future-Outlier approved these changes Jan 12, 2026

View reviewed changes

Future-Outlier moved this to can be merged in @Future-Outlier's kuberay project Jan 12, 2026

Future-Outlier added this to @Future-Outlier's kuberay project Jan 12, 2026

rueian approved these changes Jan 12, 2026

View reviewed changes

rueian merged commit 81c526d into ray-project:master Jan 12, 2026
29 checks passed

github-project-automation bot moved this from can be merged to Done in @Future-Outlier's kuberay project Jan 12, 2026

ikchifo deleted the kubectl-plugin/fieldselector-reactor-tests branch January 12, 2026 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[kubectl-plugin][Test] Use client-go reactors for FieldSelector filtering in fake client tests #4361

[kubectl-plugin][Test] Use client-go reactors for FieldSelector filtering in fake client tests #4361

Uh oh!

ikchifo commented Jan 9, 2026 •

edited

Loading

Uh oh!

justinyeh1995 left a comment •

edited

Loading

Uh oh!

justinyeh1995 commented Jan 10, 2026

Uh oh!

Uh oh!

Uh oh!

ikchifo commented Jan 10, 2026

Uh oh!

justinyeh1995 commented Jan 10, 2026

Uh oh!

justinyeh1995 commented Jan 10, 2026

Uh oh!

justinyeh1995 left a comment •

edited

Loading

Uh oh!

Future-Outlier Jan 12, 2026

Uh oh!

Future-Outlier Jan 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[kubectl-plugin][Test] Use client-go reactors for FieldSelector filtering in fake client tests #4361

[kubectl-plugin][Test] Use client-go reactors for FieldSelector filtering in fake client tests #4361

Uh oh!

Conversation

ikchifo commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Before

After

What did I do?

Related issue number

Checks

Uh oh!

justinyeh1995 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinyeh1995 commented Jan 10, 2026

Uh oh!

Uh oh!

Uh oh!

ikchifo commented Jan 10, 2026

Uh oh!

justinyeh1995 commented Jan 10, 2026

Uh oh!

justinyeh1995 commented Jan 10, 2026

Uh oh!

justinyeh1995 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Future-Outlier Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Future-Outlier Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ikchifo commented Jan 9, 2026 •

edited

Loading

justinyeh1995 left a comment •

edited

Loading

justinyeh1995 left a comment •

edited

Loading