Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Job Submission][refactor 1/N] Add AgentInfo to GCSNodeInfo (… #27242

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Revert "[Job Submission][refactor 1/N] Add AgentInfo to GCSNodeInfo (… #27242

merged 2 commits into from
Jul 30, 2022

Conversation

rkooo567
Copy link
Contributor

…#26302)"

This reverts commit 14dee5f.

Why are these changes needed?

This PR makes test_ray_shutdown flaky. cc @Catch-Bull

Screen Shot 2022-07-28 at 9 50 11 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 merged commit ec69fec into ray-project:master Jul 30, 2022
@rkooo567
Copy link
Contributor Author

cc @Catch-Bull please create a PR again and fix test_ray_shutdown

@Catch-Bull Catch-Bull mentioned this pull request Jul 30, 2022
Merged
Catch-Bull added a commit that referenced this pull request Jul 30, 2022
@Catch-Bull
Revert "Revert "[Job Submission][refactor 1/N] Add AgentInfo to GCSNo…
f1d139a 
…deInfo (#26302)" (#27242)"

This reverts commit ec69fec.

Signed-off-by: Catch-Bull <burglarralgrub@gmail.com>
@Catch-Bull
Copy link
Contributor

cc @Catch-Bull please create a PR again and fix test_ray_shutdown

@rkooo567 I'm sorry about that, before merge I find the previous test did not kill all ray:: processes and make the later test fail, now it seems that this is not the whole reason.

Catch-Bull added a commit that referenced this pull request Aug 2, 2022
@Catch-Bull
Revert "Revert "[Job Submission][refactor 1/N] Add AgentInfo to GCSNo…
68c44fe 
…deInfo (#26302)" (#27242)"

This reverts commit ec69fec.

Signed-off-by: Catch-Bull <burglarralgrub@gmail.com>
Catch-Bull added a commit that referenced this pull request Aug 4, 2022
@Catch-Bull
Revert "Revert "[Job Submission][refactor 1/N] Add AgentInfo to GCSNo…
4d5f481 
…deInfo (#26302)" (#27242)"

This reverts commit ec69fec.

Signed-off-by: Catch-Bull <burglarralgrub@gmail.com>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@rkooo567
Revert "[Job Submission][refactor 1/N] Add AgentInfo to GCSNodeInfo (r…
de22a84 
…ay-project#26302)" (ray-project#27242)

This reverts commit 14dee5f.

Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 scv119 approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@ericl ericl Awaiting requested review from ericl

@AmeerHajAli AmeerHajAli Awaiting requested review from AmeerHajAli

@robertnishihara robertnishihara Awaiting requested review from robertnishihara

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@fishbone fishbone Awaiting requested review from fishbone

Assignees

@scv119 scv119

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkooo567 @Catch-Bull @scv119