Remove show_in_dashboard function #59916
Conversation
pcmoritz
force-pushed
the
remove-webui-display
branch
from
1eaa1f7 to
1183b2f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // A string displayed on Dashboard. | ||
| map<string, string> webui_display = 7; | ||
| // Field 7 was webui_display, now removed. | ||
| reserved 7; |
There was a problem hiding this comment.
Proto file modification requires fault-tolerance review (Bugbot Rules)
Low Severity
.proto files.
Please review the RPC fault-tolerance & idempotency standards guide here:
https://github.com/ray-project/ray/tree/master/doc/source/ray-core/internals/rpc-fault-tolerance.rst
This is flagged per the user-specified BUGBOT_RULES requirement to post this message whenever .proto files are changed.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated show_in_dashboard function and all its associated components from the codebase. The changes are comprehensive, spanning across Python, Cython, C++, and Protobuf files, ensuring a clean removal of the feature. The corresponding tests in test_metrics.py have been appropriately updated to reflect these changes. Notably, the use of reserved for the removed field in the protobuf definition is a good practice that maintains backward compatibility. Overall, this is a solid contribution that improves code maintainability by removing unused code.
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
pcmoritz
force-pushed
the
remove-webui-display
branch
from
e81d041 to
95367a2
Compare
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Description
This was used early in the development of the Ray Dashboard and is not used any more so we should remove it (I recently came across this).