-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[core][docs] Update misleading Ray job diagram #59940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Ray job submission diagram to be more accurate, reflecting two primary ways to run a job instead of three. The change involves replacing the old SVG diagram with a new PNG version and updating the corresponding markdown file. The change is clear and achieves its goal. I've added one suggestion to consider using SVG format for the new diagram for better scalability and quality.
…es/fix-jobs-diagram
|
I noticed that in the doc https://docs.ray.io/en/latest/cluster/running-applications/job-submission/index.html, the "Running Jobs Interactively" section still includes Ray Client. However, when using Ray Client, the Python driver runs on the local machine, which may be worth clarifying in the docs. |
…es/fix-jobs-diagram
20df9ad to
598633f
Compare
Good call out, but in general we want to de-emphasize using Ray Client. It's listed as "experts only" in that docs page, so I'd prefer to leave it out of the diagram. |
|
Manually checked the rendering of the image, looks good |
Before:
After: