Skip to content

Conversation

@andrew-anyscale
Copy link
Contributor

Currently seeing issues of crane not available in the uploading
environment. Default to Docker if crane is not available

https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198

Topic: crane-fix

Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Jan 14, 2026

Reviews in this chain:
#60125 ci: install crane in forge image
 └#59969 wanda python-agnostic ray-cpp wheel (py3-none tag)(x86_64)
  └#59936 Add wanda ray image builds for Docker Hub
   └#59937 Add wanda anyscale image builds for release tests

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Jan 14, 2026

# head base diff date summary
0 be2c5c4e 8d27704a diff Jan 13 17:03 PM 1 file changed, 18 insertions(+), 2 deletions(-)
1 9cb14c92 8d27704a diff Jan 13 17:09 PM 2 files changed, 11 insertions(+), 18 deletions(-)
2 c9d30e15 8d27704a diff Jan 13 17:09 PM 0 files changed
3 daea687d 8d27704a diff Jan 13 17:12 PM 1 file changed, 2 insertions(+), 2 deletions(-)
4 19505953 8d27704a diff Jan 13 17:14 PM 1 file changed, 14 insertions(+), 4 deletions(-)

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fallback to Docker in extract_wanda_wheels.sh for when the crane tool is unavailable. The script now checks for crane and, if not present, uses docker create and docker export to extract files from the container image. A cleanup function is added with a trap to ensure that any created Docker containers and temporary directories are removed on script exit. The implementation is solid and effectively addresses the issue of crane not being available in all environments. I have one minor suggestion to improve error visibility during the cleanup process.

Currently seeing issues of crane not available in the uploading
environment. Installing crane on forge image.

https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198

Topic: crane-fix

Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/crane-fix branch from be2c5c4 to 9cb14c9 Compare January 14, 2026 01:09
@andrew-anyscale andrew-anyscale requested a review from a team as a code owner January 14, 2026 01:09
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/crane-fix branch from 9cb14c9 to c9d30e1 Compare January 14, 2026 01:09
@andrew-anyscale andrew-anyscale changed the title fix: extract_wanda_wheels falls back to docker ci: install crane in forge image Jan 14, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/crane-fix branch 2 times, most recently from daea687 to 1950595 Compare January 14, 2026 01:14
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Jan 14, 2026
@aslonnie aslonnie self-requested a review January 14, 2026 01:25
@ray-gardener ray-gardener bot added the devprod label Jan 14, 2026
@aslonnie
Copy link
Collaborator

getting this merge for now; maybe can follow up to change the script to bazel py_binary in the future.

@aslonnie aslonnie merged commit 8ca8eac into master Jan 14, 2026
6 of 7 checks passed
@aslonnie aslonnie deleted the andrew/revup/master/crane-fix branch January 14, 2026 02:59
rushikeshadhav pushed a commit to rushikeshadhav/ray that referenced this pull request Jan 14, 2026
Currently seeing issues of crane not available in the uploading
environment. Default to Docker if crane is not available


https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198

Topic: crane-fix

Signed-off-by: andrew <andrew@anyscale.com>

Signed-off-by: andrew <andrew@anyscale.com>
jeffery4011 pushed a commit to jeffery4011/ray that referenced this pull request Jan 20, 2026
Currently seeing issues of crane not available in the uploading
environment. Default to Docker if crane is not available

https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198

Topic: crane-fix

Signed-off-by: andrew <andrew@anyscale.com>

Signed-off-by: andrew <andrew@anyscale.com>
Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants