-
Notifications
You must be signed in to change notification settings - Fork 7.1k
ci: install crane in forge image #60125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a fallback to Docker in extract_wanda_wheels.sh for when the crane tool is unavailable. The script now checks for crane and, if not present, uses docker create and docker export to extract files from the container image. A cleanup function is added with a trap to ensure that any created Docker containers and temporary directories are removed on script exit. The implementation is solid and effectively addresses the issue of crane not being available in all environments. I have one minor suggestion to improve error visibility during the cleanup process.
Currently seeing issues of crane not available in the uploading environment. Installing crane on forge image. https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198 Topic: crane-fix Signed-off-by: andrew <andrew@anyscale.com>
be2c5c4 to
9cb14c9
Compare
9cb14c9 to
c9d30e1
Compare
daea687 to
1950595
Compare
|
getting this merge for now; maybe can follow up to change the script to bazel |
Currently seeing issues of crane not available in the uploading environment. Default to Docker if crane is not available https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198 Topic: crane-fix Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: andrew <andrew@anyscale.com>
Currently seeing issues of crane not available in the uploading environment. Default to Docker if crane is not available https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198 Topic: crane-fix Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: jeffery4011 <jefferyshen1015@gmail.com>
Currently seeing issues of crane not available in the uploading
environment. Default to Docker if crane is not available
https://buildkite.com/ray-project/postmerge/builds/15375/steps/canvas?jid=019bb99d-6f9e-45fa-92e3-a5a1d9373e8d#019bb99d-6f9e-45fa-92e3-a5a1d9373e8d/L198
Topic: crane-fix
Signed-off-by: andrew andrew@anyscale.com