[rtext] BMFont loading, support RGB and RGBA image formats #4730
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@GithubPrankster I'm seeing multiple points of improvement on this PR. In case of GRAYSCALE only, it can be converted to GRAYSCALE+ALPHA but in case of an image with already provided Alpha, it can use the full RGB color. Also, the changes do not follow raylib coding conventions: parenthesis on conditions, brackets alignment, operations symbols spacing, not enum types... |
raysan5
changed the title
So it should just be a copy of the image? |
| // Convert image to GRAYSCALE + ALPHA, using the mask as the alpha channel | ||
|
|
||
| Image imFont = { | ||
| .data = RL_CALLOC(imFonts[i].width * imFonts[i].height, 2), |
Check failure
Code scanning / CodeQL
Uncontrolled allocation size High
|
@GithubPrankster I'm afraid I'm not merging this change, the approach of picking up R channel in any case (using stride) is not the desired behaviour. |
With this PR, if the BMFont file points to images that aren't grayscale, they will now load and be converted. This allows the images to be, for example, .qoi ones which are solely RGBA.
I'm curious if failing the format check should throw a log warning, let me know and I'll add that.EDIT: Subsequently added a log warning.