Skip to content

Code review and improvements#8

Merged
razeghi71 merged 4 commits intomainfrom
cursor/code-review-and-improvements-36ba
Jan 7, 2026
Merged

Code review and improvements#8
razeghi71 merged 4 commits intomainfrom
cursor/code-review-and-improvements-36ba

Conversation

@razeghi71
Copy link
Owner

@razeghi71 razeghi71 commented Jan 7, 2026

Note

Strengthens path handling and stabilizes downloading behavior.

  • Refactors BucketWithPrefix to take Sequence[str] and adds from_full_prefix; guards against string misuse and normalizes internal state; updates all call sites (storage, file_list_view, util).
  • get_gcs_bucket_and_prefix now builds BucketWithPrefix via from_full_prefix and defaults empty prefix to "".
  • GCS.list_prefix/list_all_blobs now construct entries via from_full_prefix.
  • Downloader improvements: caches blob listing, sets ProgressBar.total from worker thread via call_from_thread, performs all UI updates thread-safely, uses daemon thread, and preserves directory structure when downloading by computing relative paths from base prefix; cooperative stop on unmount.
  • UI/logic tweaks: safer selection handling in FileListView, uses from_full_prefix when navigating, more robust BadRequest parsing, corrected confirmation text; gcp_project typed as Optional[str].

Written by Cursor Bugbot for commit c57babe. This will update automatically on new commits. Configure here.

Co-authored-by: razeghi71 <razeghi71@gmail.com>
@cursor
Copy link

cursor bot commented Jan 7, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Co-authored-by: razeghi71 <razeghi71@gmail.com>
@razeghi71 razeghi71 marked this pull request as ready for review January 7, 2026 19:25
@razeghi71 razeghi71 added bug Something isn't working patch Patch semver and removed bug Something isn't working labels Jan 7, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursoragent and others added 2 commits January 7, 2026 19:38
Co-authored-by: razeghi71 <razeghi71@gmail.com>
Co-authored-by: razeghi71 <razeghi71@gmail.com>
@razeghi71 razeghi71 merged commit 6e7b3c7 into main Jan 7, 2026
@razeghi71 razeghi71 deleted the cursor/code-review-and-improvements-36ba branch January 7, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch semver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants