refactor: requested changes

razor-network · Apr 11, 2024 · 9218d2f · 9218d2f
1 parent 28cb8c2
commit 9218d2f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/accounts/accounts.go b/accounts/accounts.go
@@ -13,9 +13,7 @@ import (
 	"strings"
 )
 
-var (
-	log = logger.NewLogger()
-)
+var log = logger.NewLogger()
 
 //This function takes path and password as input and returns new account
 func (am *AccountManager) CreateAccount(keystorePath string, password string) accounts.Account {

diff --git a/cmd/vote_test.go b/cmd/vote_test.go
@@ -280,19 +280,20 @@ func TestCalculateSecret(t *testing.T) {
 			accountManager := accounts.NewAccountManager(testKeystorePath)
 			account := accounts.InitAccountStruct(tt.args.address, tt.args.password, accountManager)
 			gotSignature, gotSecret, err := cmdUtils.CalculateSecret(account, tt.args.epoch, testKeystorePath, tt.args.chainId)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("CalculateSecret() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
 
 			gotSignatureInHash := hex.EncodeToString(gotSignature)
 			gotSecretInHash := hex.EncodeToString(gotSecret)
+
 			if !reflect.DeepEqual(gotSignatureInHash, tt.wantSignature) {
 				t.Errorf("CalculateSecret() Signature = %v, want %v", gotSignatureInHash, tt.wantSignature)
 			}
 			if !reflect.DeepEqual(gotSecretInHash, tt.wantSecret) {
 				t.Errorf("CalculateSecret() Secret = %v, want %v", gotSecretInHash, tt.wantSecret)
 			}
-			if (err != nil) != tt.wantErr {
-				t.Errorf("CalculateSecret() error = %v, wantErr %v", err, tt.wantErr)
-				return
-			}
 		})
 	}
 }