refactor: used a common http client for all the requests #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yashk767 why are the tests failing? |
ashish10677
approved these changes
Mar 20, 2024
SkandaBhat
suggested changes
Mar 28, 2024
| "time" | ||
| ) | ||
|
|
||
| var httpClient *http.Client |
There was a problem hiding this comment.
DO not use global variables. Use a struct and implement methods. cc: @ashish10677
|
Closing this. Please reopen after updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used a common http client to avoid opening a new connection on every
client.Do()call for every API.A single http client makes the node to reuse the existing connections from connection pool.
Fixes #1197 , https://linear.app/interstellar-research/issue/RAZ-771
How Has This Been Tested?
Ran a node on local and staging environment with 5 min epoch time.