Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added context with timeout to retry mechanism #1235

Conversation

Yashk767
Copy link
Contributor

@Yashk767 Yashk767 commented Sep 11, 2024

Description

Added context as a parameter to generic retry function InvokeFunctionwithretryAttempts which enables to exit from retry mechanism if the timeout for state change has occured.

Fixes https://linear.app/interstellar-research/issue/RAZ-940

How Has This Been Tested?

Ran a node with the following scenarios:

  • RPC is delaying to respond and state changes so context times out.
  • RPC is not responding case.
  • Regular happy case scenario.
  • when RPC switches to alternate client case when all retries attempts fail.

@Yashk767 Yashk767 marked this pull request as ready for review September 12, 2024 10:44
cmd/cmd-utils.go Show resolved Hide resolved
@ashish10677 ashish10677 self-requested a review September 16, 2024 12:14
ashish10677
ashish10677 previously approved these changes Sep 16, 2024
@Yashk767 Yashk767 marked this pull request as draft October 1, 2024 09:38
@Yashk767 Yashk767 changed the base branch from feature/v2.0.0 to develop October 1, 2024 09:51
@Yashk767 Yashk767 dismissed ashish10677’s stale review October 1, 2024 09:51

The base branch was changed.

@Yashk767 Yashk767 force-pushed the yash/raz-940-revise-number-of-retries-and-retry-delays-for-5-min-epoch branch from 4985434 to ba77104 Compare October 1, 2024 10:12
@Yashk767 Yashk767 marked this pull request as ready for review October 1, 2024 10:27
@ashish10677 ashish10677 self-requested a review October 1, 2024 10:57
ashish10677
ashish10677 previously approved these changes Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants