feat: added commitment verification layer for data during reveal after removing waitForBlockCompletion check for voting transactions #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashk767
added
work in progress
do not merge
and removed
work in progress
do not merge
labels
Yashk767
force-pushed
the
yash/raz-1024-check-if-we-even-need-to-consider-waitforblockcompletion-for
branch
from
4ed9a06 to
51e3bd5
Compare
ashish10677
requested changes
Oct 14, 2024
…confirmBlock when node just started voting
Yashk767
force-pushed
the
yash/raz-1024-check-if-we-even-need-to-consider-waitforblockcompletion-for
branch
from
1e6cf73 to
4513fbc
Compare
…reused it in reveal
ashish10677
approved these changes
Oct 16, 2024
rajkharvar
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the WaitForBlockCompletion for voting transactions Which required some validations needed to be added to make vote work correctly.
So there was a need to check whether commitment calculated form the commit data fetched from memory during reveal state should be equal to commitment committed suring commit state.
If this check for commitment is verified thn only the node can use the same data during reveal.
Even during confirm state, node used to save the lastConfirmed check based on confirm transaction status , so that check is now replaced with checking whether is there a block confirmed in the epoch.
Fixes https://linear.app/interstellar-research/issue/RAZ-1024
How Has This Been Tested?